NextJS: Fix v13 next/link
#19834
Merged
NextJS: Fix v13 next/link
#19834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylegach
force-pushed
the
fix-next-13-link
branch
from
f4c4809
to
36ec879
Compare
|
These CI failures seem unrelated? |
valentinpalkovic
approved these changes
Nov 15, 2022
kylegach
force-pushed
the
fix-next-13-link
branch
from
36ec879
to
b8475b9
Compare
|
At Yann's suggestion, I tested in |
kylegach
force-pushed
the
fix-next-13-link
branch
from
b8475b9
to
cc62687
Compare
kylegach
commented
Nov 18, 2022
kylegach
force-pushed
the
fix-next-13-link
branch
from
4173604
to
223f969
Compare
|
@kylegach @valentinpalkovic there's a merge conflict here -- can one of you please resolve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: vercel/next.js#42621 #19813
What I did
Applied the internal NEXT env var in the Storybook env
How to test
If your answer is yes to any of these, please make sure to include it in your PR.