Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Do not copy code snippet when text inside preview is selected #19788

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Blocks: Do not copy code snippet when text inside preview is selected #19788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d558261
fix(blocks): Do not copy snippet when preview text is selected
pocka Nov 9, 2022
6abbb54
Merge branch 'next' into pocka/fix/18611-cannot-copy-docs-preview-con…
ndelangen Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions code/ui/blocks/src/components/Preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ export const Preview: FC<PreviewProps> = ({
}, []);

const onCopyCapture = (e: ClipboardEvent<HTMLInputElement>) => {
// When the selection range is neither empty nor collapsed, we can assume
// user's intention is to copy the selected text, instead of the story's
// code snippet.
const selection: Selection | null = globalWindow.getSelection();
if (selection && selection.type === 'Range') {
return;
}

e.preventDefault();
if (additionalActionItems.filter((item) => item.title === 'Copied').length === 0) {
copyToClipboard(source.props.code).then(() => {
Expand Down