Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TS 4.9 #19646

Closed
wants to merge 4 commits into from
Closed

Upgrade to TS 4.9 #19646

wants to merge 4 commits into from

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Oct 27, 2022 •
edited

Split the TS 4.9 upgrade out of this PR:
#19462

What I did

  • Upgraded to TS 4.9 dev
  • Fixed all issues introduced by upgrading
  • Upgraded @types/node package to 18.11.6, as this was the only version that had no mismatch for the AbortSignal type between TS 4.9 dom library and the node library. Ideally, there would be a 16.x release that fixes this as well I guess.
  • Moved usage of the satisfies helper, to actually using the satisfies keyword.
  • I disabled Eslint and prettier on those files,

Blocked by

How to test

  • yarn lint
  • yarn task --task check --no-link

@kasperpeulen kasperpeulen self-assigned this Oct 27, 2022
@kasperpeulen kasperpeulen marked this pull request as draft October 27, 2022 09:09
@ndelangen
Copy link
Member

Awesome work @kasperpeulen ! 👏

@kasperpeulen kasperpeulen force-pushed the kasper/typescript-49 branch 2 times, most recently from 856eb8c to 9d14b45 Compare October 30, 2022 15:58
@kasperpeulen kasperpeulen added feature request maintenance User-facing maintenance tasks and removed feature request labels Oct 30, 2022
@kasperpeulen kasperpeulen force-pushed the kasper/typescript-49 branch 2 times, most recently from dc2acf0 to 0d7ea51 Compare October 31, 2022 14:03
@shilman
Copy link
Member

shilman commented Nov 24, 2022

@kasperpeulen What's going on with this PR?

@kasperpeulen
Copy link
Contributor Author

This one is splitted again in 3, and all merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kasperpeulen kasperpeulen

Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kasperpeulen @ndelangen @shilman