Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in docs-page #19641

Merged
merged 1 commit into from Oct 27, 2022
Merged

Conversation

raptor0929
Copy link
Contributor

What I did

A link is dead in the docs-page

I updated the link from https://github.com/storybookjs/storybook/tree/master/frameworks/vue-webpack5 to
https://github.com/storybookjs/storybook/blob/next/code/frameworks/vue-webpack5/README.md

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 27, 2022
@jonniebigodes
Copy link
Contributor

@raptor0929, thanks for the time and effort you've put into this pull request and for helping us catch that small but rather important issue with the link. We appreciate it. All is good on my end. Going to merge as soon as the checklist finishes.

Hope you have a great day.

Stay safe

@jonniebigodes jonniebigodes merged commit a07522c into storybookjs:next Oct 27, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants