Attempted link fix #19499
Merged
Attempted link fix #19499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
added
documentation
patch:yes
yannbf
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
This is wonderful! Thank you so much for your contribution @sabrinajess!
|
@sabrinajess going to merge this. Thank you for the time and effort you've put into this and for helping us improve the documentation. Hope you have a great week. Stay safe |
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19229
What I did
Changed https://github.com/storybookjs/storybook/blob/next/app/react/src/server/framework-preset-react-docs.ts to https://github.com/storybookjs/storybook/blob/next/code/presets/react-webpack/src/framework-preset-react-docs.ts
Atom also removed some superfluous end spaces for me - let me know if you want me to remove those for a cleaner PR.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.