Update telemetry.md #19469
Closed
Update telemetry.md #19469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an inconsistency between code and docs.
jonniebigodes
requested changes
Oct 16, 2022
There was a problem hiding this comment.
@dmaklygin one small item to address on this that I would like to hear from you.
Hope you have a great weekend.
Stay safe
| @@ -44,7 +44,7 @@ Access to the raw data is highly controlled, limited to select members of Storyb | |||
|
|
|||
| ## What about sensitive information? | |||
|
|
|||
| We take your privacy and our security very seriously. We perform additional steps to ensure that secure data (e.g., environment variables or other forms of sensitive data) **do not** make their way into our analytics. You can view all the information we collect by setting the `STORYBOOK_TELEMETRY_DEBUG` to `1` to print out the information gathered. For example: | |||
| We take your privacy and our security very seriously. We perform additional steps to ensure that secure data (e.g., environment variables or other forms of sensitive data) **do not** make their way into our analytics. You can view all the information we collect by setting the `STORYBOOK_DEBUG_TELEMETRY` to `1` to print out the information gathered. For example: | |||
There was a problem hiding this comment.
@dmaklygin, can you elaborate on this? Upon checking the documentation (code and snippets) this is actually correct. Unless I'm missing something the change you're introducing is actually a misconception.
jonniebigodes
added
documentation
patch:yes
shilman
added a commit
that referenced
this pull request
Oct 17, 2022
|
Thanks @dmaklygin -- this is actually a bug in the telemetry implementation & I've added a fix in #19509 that will get patched back to 6.5. Closing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between code and docs.
Issue:
What I did
Renamed env variable in docs
How to test
If your answer is yes to any of these, please make sure to include it in your PR.