Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved README.md #19400

Merged
merged 6 commits into from Dec 30, 2022
Merged

Conversation

sriram-km
Copy link
Contributor

@sriram-km sriram-km commented Oct 8, 2022

Issue:

Improved the README.md

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 8, 2022
@jonniebigodes jonniebigodes self-assigned this Oct 8, 2022
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriram-km thank you very much for taking the time and effort to update the monorepo's docs. We're truly thankful for it 🙏 ! I've already resolved the conflict that was introduced. If you wouldn't mind, there's a small item that requires your attention. Let me know once it's addressed, and I'll gladly merge this.

I hope you have a great day.

Stay safe.

README.md Outdated
@@ -158,7 +158,7 @@ We have a badge! Link it to your live Storybook example.
[![Storybook](https://cdn.jsdelivr.net/gh/storybookjs/brand@main/badge/badge-storybook.svg)](link to site)
```

If you're looking for material to use in your presentation about storybook, like logo's video material and the colors we use etc, you can find all of that at our [brand repo](https://github.com/storybookjs/brand).
If you're looking for material to use in your presentation about the storybook, like logo's video material and the colors we use etc, you can find all of that at our [brand repo](https://github.com/storybookjs/brand).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriram-km this is actually almost correct in the original form if you could update this to:

If you're looking for materials to use in your presentation about Storybook, like the logo, video materials, the colors we use, etc, you can find all of that at our [brand repo](https://github.com/storybookjs/brand).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonniebigodes first of all sorry for the late response. Done the change. Please have a look. Thanks

@jonniebigodes jonniebigodes mentioned this pull request Oct 15, 2022
3 tasks
@jonniebigodes jonniebigodes merged commit c9f2525 into storybookjs:next Dec 30, 2022
1 check passed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 10, 2023
shilman pushed a commit that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants