Generic stories for remaining core features #19118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
changed the base branch from
next
to
tom/sb-586-core-features-loaders-parameters
…b-586-remaining-core-features
shilman
reviewed
Sep 7, 2022
| await expect(button).toHaveFocus(); | ||
|
|
||
| // // When we change the args to the button, it should not rerender | ||
| // await channel.emit('updateStoryArgs', { storyId: id, updatedArgs: { children: 'New Text' } }); |
There was a problem hiding this comment.
I comment them back in in #19125. They were failing here (which is good!)
…b-586-remaining-core-features
Base automatically changed from
tom/sb-586-core-features-loaders-parameters
to
next
September 7, 2022 23:54
shilman
changed the title
|
@tmeasday I updated from the base branch but CI is still failing. Can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: following on from #19105
What I did