Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix the sb-bench CI step #19029

Merged
merged 12 commits into from
Aug 30, 2022
Merged

Build: Fix the sb-bench CI step #19029

merged 12 commits into from
Aug 30, 2022

Commits on Aug 26, 2022

  1. Configuration menu
    Copy the full SHA
    71935c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c04bc0f View commit details
    Browse the repository at this point in the history
  3. upgrades

    ndelangen committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    a78c62a View commit details
    Browse the repository at this point in the history
  4. fix the build system.

    Emotion changed to use exports map, and esbuild wasn't pivking the right entry anymore,
    resulting in react not being detected, and thus not bundled, and thus missing at runtime!
    
    I changed the tsup/esbuild config to prefer the ESM version, and this seems to have fixed the issue.
    
    Many thanks to @anderist for the assist!
    ndelangen committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    6ebde54 View commit details
    Browse the repository at this point in the history
  5. 'fix' warnings

    ndelangen committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    4b15710 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    477f41e View commit details
    Browse the repository at this point in the history
  7. so it seems that in production mode this is still an issue, so I did …

    …the suggested fix by @anderist
    
    He suggested that 'hiding' the dependency on an export that may or may not exists away from bundlers would solve it.
    This is what they do in emotion itself, but esbuild optimizes that away again.
    ndelangen committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    f8fc018 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. fix

    ndelangen committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    ccb6089 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'next' into tech/fix-bench

    # Conflicts:
    #	code/yarn.lock
    ndelangen committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    530d297 View commit details
    Browse the repository at this point in the history
  2. bump sb-bench version

    ndelangen committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    1128a2a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c9d75a9 View commit details
    Browse the repository at this point in the history
  4. update

    ndelangen committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    8af57a2 View commit details
    Browse the repository at this point in the history