-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Fix the sb-bench CI step #19029
Merged
Merged
Commits on Aug 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 71935c5 - Browse repository at this point
Copy the full SHA 71935c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c04bc0f - Browse repository at this point
Copy the full SHA c04bc0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a78c62a - Browse repository at this point
Copy the full SHA a78c62aView commit details -
Emotion changed to use exports map, and esbuild wasn't pivking the right entry anymore, resulting in react not being detected, and thus not bundled, and thus missing at runtime! I changed the tsup/esbuild config to prefer the ESM version, and this seems to have fixed the issue. Many thanks to @anderist for the assist!
Configuration menu - View commit details
-
Copy full SHA for 6ebde54 - Browse repository at this point
Copy the full SHA 6ebde54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b15710 - Browse repository at this point
Copy the full SHA 4b15710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 477f41e - Browse repository at this point
Copy the full SHA 477f41eView commit details -
so it seems that in production mode this is still an issue, so I did …
…the suggested fix by @anderist He suggested that 'hiding' the dependency on an export that may or may not exists away from bundlers would solve it. This is what they do in emotion itself, but esbuild optimizes that away again.
Configuration menu - View commit details
-
Copy full SHA for f8fc018 - Browse repository at this point
Copy the full SHA f8fc018View commit details
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ccb6089 - Browse repository at this point
Copy the full SHA ccb6089View commit details
Commits on Aug 30, 2022
-
Merge branch 'next' into tech/fix-bench
# Conflicts: # code/yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 530d297 - Browse repository at this point
Copy the full SHA 530d297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1128a2a - Browse repository at this point
Copy the full SHA 1128a2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9d75a9 - Browse repository at this point
Copy the full SHA c9d75a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8af57a2 - Browse repository at this point
Copy the full SHA 8af57a2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.