Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Fix callback behavior in react@18 #18737

Merged
merged 3 commits into from Jul 31, 2022
Merged

React: Fix callback behavior in react@18 #18737

merged 3 commits into from Jul 31, 2022

Commits on Jul 28, 2022

  1. Reinstate all react tests

    @tmeasday
    tmeasday committed Jul 28, 2022
    Copy the full SHA
    2740d17 View commit details
    Browse the repository at this point in the history

  2. Use useLayoutEffect for callback

    @tmeasday
    tmeasday committed Jul 28, 2022
    Copy the full SHA
    049d84c View commit details
    Browse the repository at this point in the history

  3. Add a Math.random() to ensure the callback is called exactly once

    @tmeasday
    tmeasday committed Jul 28, 2022
    Copy the full SHA
    b2b7a15 View commit details
    Browse the repository at this point in the history