Fix leaking @types/* from package.json dependencies

[mrauhu]

Hello.

I found that the @storybook/components package is leaking the @types/react package to a Vue project node_modules directory:

npm ls @types/react

my-vue-project@0.0.0
`-- @my-vue-project/storybook@0.0.0 -> ./packages/storybook
  `-- @storybook/addon-a11y@6.4.22
    `-- @storybook/components@6.4.22
      `-- @types/react-syntax-highlighter@11.0.5       
        `-- @types/react@18.0.8

This results to a bug with the vue-tsc package: vuejs/language-tools#592.

So, I check all package.json files in the Storybook repository and fix them.

What I did

Moved @types/* packages from dependencies to devDependencies in package.json files.

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

Best wishes,
Sergey.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 33f6851. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[mrauhu]

@Andarist thank you for suggestions.

I rechecked export in generated *.d.ts files and moved to devDependencies only not exported @types/* packages.

[shilman]

This was already fixed in next in another PR, see comment #18323 (comment)

We don't feel comfortable merging these changes without a way to verify that they don't disrupt TS users. Thanks so much for your contribution & patience @mrauhu !!!

[ndelangen]

Hello @mrauhu I'm going to close this... I think all relevant bits got merged / fixed in a few other PRs already, the react-syntax-highlighter should at least be fixed, and the other types changes don't look right me me.

Thank you the work you did, very much appreciated!

[mrauhu]

Thank you.