Run prebundle script without browser: true in Rollup config
#17947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7b370a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
ok, I get it.. looks like all lights on green based on the CI, and this might actually fix https://github.com/kylegach/storybook-theming-bundling-bug-2
|
I suspect this PR might be related to #17978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tricky PR - but ultimately I think it's for the better. The problem is that there is a chance that you might want to use
browser: truefor some packages but not for some other ones (like Emotion). There is no way to control this per-package though and since you don't control the consuming environment, you can't assume that it's going to be a browser - so, in a way, this setting was used incorrectly here.However, there is some chance that not using it might break something - it's quite hard to test it though unless you already know what it might break or if automated tests (or manual smoke tests) show the problem.