Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export createCache from @storybook/theming #17929

Merged
merged 1 commit into from Apr 11, 2022
Merged

Conversation

Andarist
Copy link
Contributor

Since you bundle Emotion stuff at the moment - it's probably best to export this from here (it's already bundled anyway since it's used internally by Emotion). This will allow other consuming projects (such as Chromatic) to reuse the bundled createCache without having to add dependency on @emotion/cache and thus duplicating its code.

@nx-cloud
Copy link

nx-cloud bot commented Apr 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 82fcd20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Apr 11, 2022
@ndelangen ndelangen merged commit 7e548dc into next Apr 11, 2022
@ndelangen ndelangen deleted the export-create-cache branch April 11, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants