CLI: Add webpack4/5 detection #17908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependencies from core-server at some point
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ef8085. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
|
😎 |
|
How can I set which webpack version I want storybook to use after this update? |
|
@daniel-stoian-lgp you can set the https://storybook.js.org/docs/6.5/react/configure/webpack#webpack-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The CLI can now detect which version of webpack you are using. If it detects you have webpack version 4 installed anywhere, it will use builder-webpack4, if you do not, and you have webpack v5 installed instead, it will use builder-webpack5.
It will still default to use builder-webpack4 if it can't detect anything.
I also added the builder-webpack4 and manager-webpack4 in the case the builder is indeed webpack4. Seems like the right thing to do, if we don't want core-server to depend on any builder in particular.