Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix canvas as initialActive for fullscreen mode in mobile #17906

Merged
merged 1 commit into from Apr 7, 2022
Merged

UI: Fix canvas as initialActive for fullscreen mode in mobile #17906

merged 1 commit into from Apr 7, 2022

Conversation

JonathanKolnik
Copy link
Contributor

@JonathanKolnik JonathanKolnik commented Apr 6, 2022 •
edited

Issue:
If initialActive was configured to 'sidebar', it would cause the sidebar to show up in fullscreen mode within the mobile layout.

What I did

Check for isFullscreen when setting the initial active state within the Mobile component.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19de11a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JonathanKolnik JonathanKolnik force-pushed the jono/ch-1793-the-sidebar-is-still-appearing-in branch from fac1a0f to 7656439 Compare April 6, 2022 17:06
@JonathanKolnik JonathanKolnik changed the title Set canvas as initial state in designEmbed Set canvas as initial state for mobile in fullscreen mode Apr 6, 2022
@JonathanKolnik JonathanKolnik changed the title Set canvas as initial state for mobile in fullscreen mode Set canvas as initialActive for mobile in fullscreen mode Apr 6, 2022
@JonathanKolnik JonathanKolnik force-pushed the jono/ch-1793-the-sidebar-is-still-appearing-in branch from 7656439 to 19de11a Compare April 6, 2022 17:16
@JonathanKolnik JonathanKolnik marked this pull request as ready for review April 6, 2022 17:17
@shilman shilman changed the title Set canvas as initialActive for mobile in fullscreen mode UI: Fix canvas as initialActive for fullscreen mode in mobile Apr 7, 2022
@shilman shilman added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 7, 2022
shilman
shilman approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@shilman shilman merged commit 6ade743 into storybookjs:next Apr 7, 2022
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanKolnik @shilman