Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add story preloading to optimize lazy compilation #17903

Merged
merged 13 commits into from Apr 8, 2022
Merged

Core: Add story preloading to optimize lazy compilation #17903

merged 13 commits into from Apr 8, 2022

Commits on Apr 5, 2022

  1. add event for preloading stories on channel

    @ndelangen
    ndelangen committed Apr 5, 2022
    Copy the full SHA
    7dbcbb7 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. change name of the event

    @ndelangen
    ndelangen committed Apr 6, 2022
    Copy the full SHA
    ed05f67 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @ndelangen
    ndelangen committed Apr 6, 2022
    Copy the full SHA
    10d0802 View commit details
    Browse the repository at this point in the history

  3. add api for finding sibling storyId

    @ndelangen
    ndelangen committed Apr 6, 2022
    Copy the full SHA
    6757327 View commit details
    Browse the repository at this point in the history

  4. fix incorrect boolean & add tests

    @ndelangen
    ndelangen committed Apr 6, 2022
    Copy the full SHA
    5c7cc8c View commit details
    Browse the repository at this point in the history

  5. call preloadStories with a list of related stories when story changed

    @ndelangen
    ndelangen committed Apr 6, 2022
    Copy the full SHA
    3e72da2 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Merge branch 'next' into feat/add-lazyload-event 

    # Conflicts:
#	lib/preview-web/src/PreviewWeb.tsx
    @ndelangen
    ndelangen committed Apr 7, 2022
    Copy the full SHA
    1eb2cdb View commit details
    Browse the repository at this point in the history

  2. fix review comments & add a unit-test

    @ndelangen
    ndelangen committed Apr 7, 2022
    Copy the full SHA
    c6e9ee0 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @ndelangen
    ndelangen committed Apr 7, 2022
    Copy the full SHA
    02a2ba3 View commit details
    Browse the repository at this point in the history

  4. change implementation to preload stories only when the STORY_PREPARED… 

    … is emitted

This only happens when StoryStoreV7 is enabled
    @ndelangen
    ndelangen committed Apr 7, 2022
    Copy the full SHA
    ff78d13 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Update lib/core-events/src/index.ts 

    Co-authored-by: Tom Coleman <tom@chromatic.com>
    @ndelangen @tmeasday
    ndelangen and tmeasday committed Apr 8, 2022
    Copy the full SHA
    d4b476b View commit details
    Browse the repository at this point in the history

  2. Update lib/preview-web/src/PreviewWeb.test.ts 

    Co-authored-by: Tom Coleman <tom@chromatic.com>
    @ndelangen @tmeasday
    ndelangen and tmeasday committed Apr 8, 2022
    Copy the full SHA
    acb4303 View commit details
    Browse the repository at this point in the history

  3. fix unit tests

    @ndelangen
    ndelangen committed Apr 8, 2022
    Copy the full SHA
    c01880d View commit details
    Browse the repository at this point in the history