Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile fullscreen UI #17873

Merged
merged 5 commits into from Apr 6, 2022
Merged

Fix mobile fullscreen UI #17873

merged 5 commits into from Apr 6, 2022

Conversation

LucaCras
Copy link
Contributor

@LucaCras LucaCras commented Apr 4, 2022

Issue: #17808

What Pepijn and I did

  • Show fullscreen toggle button on mobile UI
  • Hide nav when fullscreen active

How to test

Open an example storybook, change the screen size to < 600px, then check if the fullscreen button is visible and whether the nav is hidden when fullscreen is active.

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Apr 4, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c07e5d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@LucaCras LucaCras changed the title 17808 fix mobile fullscreen Fix mobile fullscreen UI Apr 4, 2022
@kylegach kylegach self-assigned this Apr 4, 2022
@yannbf
Copy link
Member

yannbf commented Apr 5, 2022

Hey @LucaCras and @Pepijnk12 thanks a lot for this!! I noticed a small detail I wanted to share with you.

The full screen functionality on mobile is not 100% fullscreen because the height of the story doesn't change, it's only the tabs which get hidden, This means that the scroll area is not taking the entire screen as you can see here:

image

I highlighted some css which is taking the nav height into account, which is why it's not 100% fullscreen. Could you take a look at that? Thanks!!

@LucaCras
Copy link
Contributor Author

LucaCras commented Apr 5, 2022

Hey @LucaCras and @Pepijnk12 thanks a lot for this!! I noticed a small detail I wanted to share with you.

The full screen functionality on mobile is not 100% fullscreen because the height of the story doesn't change, it's only the tabs which get hidden, This means that the scroll area is not taking the entire screen as you can see here:

image

I highlighted some css which is taking the nav height into account, which is why it's not 100% fullscreen. Could you take a look at that? Thanks!!

Hey @yannbf, thanks for pointing this out! Totally missed it ;)

But I have added a change that should fix this. Let me know if I did it correctly

@LucaCras LucaCras requested a review from kylegach April 5, 2022 19:19
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @LucaCras! Thank you again for the helpful improvement and the responsive (no pun intended 😝) back-and-forth!

@kylegach kylegach merged commit e973eea into next Apr 6, 2022
@kylegach kylegach deleted the 17808-fix-mobile-fullscreen branch April 6, 2022 16:04
@shilman shilman mentioned this pull request Apr 7, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants