Update react-test-renderer version

[souppower]

Issue: #17831 (comment)

What I did

I updated react-test-renderer to version 18.

The version we had depended on react 17, but this PR should fix the peerDeps problem.
https://github.com/facebook/react/blob/main/packages/react-test-renderer/package.json#L26-L28

@cameron-martin @jcerri Thanks for telling me about this issue! 🙌

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dfc3607. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[souppower]

Test is failing with calls to a deprecated function 'isBatchingLegacy' in react-test-renderer

[cameron-martin]

I think this is due to having a mixture of different versions between different react packages. Looks like a lot of versions of react packages are on version 16 when installing these locally. I think this is because a bunch of dev dependencies depend on react 16, for example enzyme-adapter-preact.

[souppower]

@cameron-martin You sound right.

FYI, this line looks like where the error was thrown from.
ReactCurrentActQueue is undefined, so referencing ReactCurrentActQueue.isBatchingLegacy throws.
https://github.com/facebook/react/blob/fc47cb1b61ac012f9bd6d7251eb19fcecf364a3b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js#L790

[yannbf]

Hey @souppower thank you so much for this contribution! @ndelangen could you check this out?

[souppower]

I'll look into this at the weekend if I have time.

[ndelangen]

I think we need a devDependency on the version we're currently using in the monorepo; otherwise yarn might install a too new of a version if we regenerate the lockfile.

Could you add this?

[ndelangen]

Looks like the unit test are failing because of the update, could you have a look?
https://app.circleci.com/pipelines/github/storybookjs/storybook/25536/workflows/5f9b2073-68d0-44cc-b528-962a226d74a3/jobs/378122
🙏

[souppower]

@ndelangen Thanks for your feedback!

I think we need a devDependency on the version we're currently using in the monorepo; otherwise yarn might install a too new of a version if we regenerate the lockfile.

Could you add this?

Did you mean that I should move react-test-renderer in dependencies to devDependencies?

[souppower]

Yes, the unit test is failing because of these 'isBatchingLegacy' of undefined errors.

Maybe I should first check what change has been made to react-test-renderer changed since version 17?
https://github.com/facebook/react/commits/main/packages/react-test-renderer

[souppower]

Looks like react-test-renderer 18 is not meant to be used with older react.
We probably cannot be able to upgrade react-test-renderer before upgrading react and react-dom in this repo first 🤔

[souppower]

Let me close this old PR as I don't know how to get this to work 🙏

If anyone manages to get this to work, you can either open a new PR or reopen this PR.