Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix vite/jest issue with mocked global #17830

Merged
merged 2 commits into from Mar 31, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 30, 2022

Issue: #17516

What I did

How to test

yarn build cli
cd /path/to/vite-project
/path/to/storybook/lib/cli/bin/index.js init --builder vite
# or --builder @storybook/builder-vite

@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cc6fa20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit ef2baa4 into next Mar 31, 2022
@shilman shilman deleted the feat/cli-add-vite-builder branch March 31, 2022 11:11
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Apr 1, 2022
shilman added a commit that referenced this pull request Apr 1, 2022
CLI: Fix vite/jest issue with mocked global
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug builder-vite cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants