Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove __namedExportsOrder handling from store" #17793

Closed

Conversation

joshwooding
Copy link
Contributor

Issue: Ordering is broken in the docs view for ES module environments e.g. vite builder storybookjs/builder-vite#227

What I did

Reverted commit 0787dfc

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 24, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit a3b5e09. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman
Copy link
Member

shilman commented Mar 25, 2022

Thanks @joshwooding! However, I don't think this is the right fix to the problem. I'll take a closer look early next week and hopefully can suggest a fix that's more in line with how sorting works since 6.4

@IanVS
Copy link
Member

IanVS commented Apr 1, 2022

Sounds like this was addressed by #17669. I think this PR can be closed.

@shilman shilman closed this Apr 1, 2022
@joshwooding joshwooding deleted the fix-named-exports-sorting branch April 1, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants