Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Core: Rename generated-stories-entry to cjs extension so require works" #17361

Merged
merged 1 commit into from Jan 28, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 28, 2022

Reverts #16727 which causes Storybook to fail in CRA5 per the comment in #17329

cc @tmeasday @ndelangen

@shilman shilman added bug core cra Prioritize create-react-app compatibility labels Jan 28, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 28, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 62f3120.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core cra Prioritize create-react-app compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant