Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/Svelte: Revert template stories from svelte-native to CSF #17340

Merged
merged 1 commit into from Jan 28, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 26, 2022

Issue: N/A

What I did

Revert template stories from svelte-native to CSF

  • Story Store v7 compatibility
  • Consistency with rest of documentation & storybook idioms
  • Move towards possible future deprecation of svelte-native format

How to test

npx degit sveltejs/template new-svelte-test
cd new-svelte-test/
~/path/to/storybook/lib/cli/bin/index.js init

@shilman shilman added maintenance User-facing maintenance tasks cli svelte labels Jan 26, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit f1734b6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes
Copy link
Contributor

@shilman ran it locally against my Storybook set up and it's working great in development/publish mode. Feel free to merge it when you're able.

@shilman shilman merged commit 208710f into next Jan 28, 2022
@shilman shilman deleted the svelte-cli-template-csf branch January 28, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks svelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants