Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix negated glob support #17328

Merged
merged 2 commits into from Jan 28, 2022
Merged

Core: Fix negated glob support #17328

merged 2 commits into from Jan 28, 2022

Conversation

clentfort
Copy link
Contributor

@clentfort clentfort commented Jan 25, 2022 •
edited by shilman

Issue: #16964

Summary:

Support negated globs like ../!(negation)/*.stories.mdx in storybook
config.

Related issues:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@clentfort
fix(core-common): support negated globs
56444ef 
# Summary:

Support negated globs like `../!(negation)/*.stories.mdx` in storybook
config.

**Related issues:**

Closes storybookjs#16964
@nx-cloud
Copy link

nx-cloud bot commented Jan 25, 2022 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit 5d476f0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@clentfort
Copy link
Contributor Author

@tmeasday as discussed here I moved the scan before the if and use the result to determine the correct behaviour.

tmeasday
tmeasday approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really appreciate this @clentfort

@clentfort
Copy link
Contributor Author

One ci run failed. Is this expected? Do I need to do anything?

@tmeasday tmeasday added bug core patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 27, 2022
@shilman shilman changed the title fix(core-common): support negated globs Core: Fix negated glob support Jan 28, 2022
@shilman shilman merged commit 7669653 into storybookjs:next Jan 28, 2022
@shilman shilman mentioned this pull request Jan 28, 2022
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 28, 2022
shilman added a commit that referenced this pull request Jan 28, 2022
@shilman
Merge pull request #17328 from clentfort/fix/16964-negated-globs
860d156 
Core: Fix negated glob support
@clentfort clentfort deleted the fix/16964-negated-globs branch January 28, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clentfort @tmeasday @shilman