Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Ensure that __DOCS_CONTEXT__ cannot be undefined #17251

Merged
merged 2 commits into from Feb 21, 2022

Conversation

Pewtro
Copy link
Contributor

@Pewtro Pewtro commented Jan 16, 2022

Issue:
As per this comment __DOCS_CONTEXT__ was undefined when using storybook-docs and storybook-storyshots in combination, this should fix that without causing any other change in functionality.

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 16, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 953eb2d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Pewtro Pewtro changed the title Ensure that __DOCS_CONTEXT__ cannot be undefined when using storyshots Addon-docs: Ensure that __DOCS_CONTEXT__ cannot be undefined when using storyshots Jan 16, 2022
@Pewtro Pewtro changed the title Addon-docs: Ensure that __DOCS_CONTEXT__ cannot be undefined when using storyshots Addon-docs: Ensure that __DOCS_CONTEXT__ cannot be undefined Jan 16, 2022
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pewtro good one! Thanks for your contribution!

@yannbf yannbf merged commit 5506ff7 into storybookjs:next Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants