Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Restore webpack as a dependency, updated webpack 5 docs #17207

Merged
merged 1 commit into from Jan 12, 2022

Conversation

patrick-mcdougle
Copy link
Contributor

Issue: #17192 (comment)

What I did

Restored webpack as a dependency with a version string that's a little more flexible (matches the strictest overlap of the dependencies peers). As this could result in a separate webpack version to be installed, I also added more to the migration guide about forcing a webpack 5 resolution if the user is attempting to use builder/manager webpack 5 and is running into issues.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 11, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 29c4627. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@patrick-mcdougle patrick-mcdougle marked this pull request as draft January 11, 2022 23:00
@patrick-mcdougle patrick-mcdougle marked this pull request as ready for review January 11, 2022 23:06
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title Restore webpack as a dependency, updated webpack 5 docs React: Restore webpack as a dependency, updated webpack 5 docs Jan 12, 2022
@shilman shilman merged commit 41aa25d into storybookjs:next Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants