Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Add default render function CSF3 #17068

Merged
merged 4 commits into from Jan 3, 2022
Merged

Vue3: Add default render function CSF3 #17068

merged 4 commits into from Jan 3, 2022

Conversation

mrauhu
Copy link
Contributor

@mrauhu mrauhu commented Dec 22, 2021

Issue: #15498

Greetings.

What I did

In this pull-request I'm created a default render() function for Vue 3 and provided an example of usage with CSF3 story.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

Testing

  1. Build @storybook/vue3 package:

    yarn build vue3
    
  2. Run Vue 3 CLI example:

    cd examples/vue-3-cli-example
    yarn storybook
    
  3. Open ButtonCSF3 Storybook page in a browser.
    You will see a rendered Vue 3 component.

Best wishes,
Sergey.

@nx-cloud
Copy link

nx-cloud bot commented Dec 22, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 263eb02. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title CSF3: Default render function for the Vue 3 framework Vue3: Add default render function CSF3 Jan 3, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrauhu this is awesome!! ❤️

@shilman shilman merged commit 6796c21 into storybookjs:next Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants