Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MIGRATION instructions for Angular 13 / SB6.4 for Angular #16980

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 10, 2021

Issue: #16950

What I did

Documented latest changes to Angular per various PRs and issue comments

How to test

N/A

@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 1daec22. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@shilman shilman merged commit e51ec39 into next Dec 10, 2021
@shilman shilman deleted the docs/angular-6-4-migration branch December 10, 2021 18:05
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 27, 2021
shilman added a commit that referenced this pull request Dec 27, 2021
Added MIGRATION instructions for Angular 13 / SB6.4 for Angular
If you need storybook-specific styles separate from your app, you can configure the styles in the [SB Angular builder](#sb-angular-builder), which completely overrides your project's styles:

```json
"storybook": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman see #16950 (comment) -- I don't know if this is specific to the @nrwl/nx set ups or not, but I specifically needed to put this in the build-storybook stanza that follows, NOT the storybook one here. I don't have time to update migration guide, sorry, but just a heads up for posterity and others searching until docs proper get updated.

"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"styles": ["src/styles.css", "src/styles.scss"],
Copy link

@pixtim pixtim Jan 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we use global SCSS in storybook with Angular 13 libraries? We're using the @nrwl/angular:package executor from Nx workspaces. It doesn't have an option to add global style sheets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants