Remove reference to "normal" theme, change to "light" #16927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportWe didn't find any information for the current pull request with the commit 940b455. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
jonniebigodes
added
documentation
patch:yes
|
@richorrichard thanks for taking the time and effort you've put into this pull request and your willingness to work on the issue. I've checked and documentation wise it looks good on my end. Going to self merge this. Have a great week! Stay safe |
|
Thanks @jonniebigodes ! I opened up the new issue for updating the codebase here: #16937 and will be starting to work on my PR later today for that as well. Cheers, and have a great week! |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Dec 9, 2021
…s-wording-normal-to-light Remove reference to "normal" theme, change to "light"
richorrichard
deleted the
15631-change-theming-docs-wording-normal-to-light
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Storybook Theming: Remove use of "normal" theme and language #15631
What I did
Updated configuration > theming documentation to use 'light' instead of 'normal'
How to test
If your answer is yes to any of these, please make sure to include it in your PR.