Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix incorrect log #16885

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

avergos29
Copy link
Contributor

@avergos29 avergos29 commented Dec 3, 2021

Issue: #16884

When starting angular I got this error
ERR! => Could not find angular project: Cannot convert object to primitive valueTypeError: Cannot convert object to primitive value
info => Fail to load angular-cli config. Using base config

What I did

Origin is in framework-preset-angular-cli.ts l.175.

This line
logger.info(=> Using angular project "${project}:${target}" for configuring Storybook);
should be replaced by
logger.info(=> Using angular project "${project}:${browserTarget.target}" for configuring Storybook);

Because target is an object, it cannot be used in the logger

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 3, 2021

Nx Cloud Report

CI ran the following commands for commit 3dbfa80. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added angular bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 3, 2021
@shilman shilman changed the title fix incorrect log Angular: Fix incorrect log Dec 3, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, my bad! Thanks for the fix @avergos29 !!

@shilman shilman merged commit 5182f9c into storybookjs:next Dec 3, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 3, 2021
shilman added a commit that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants