Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactions: Unlock controls when play function is finished #16784

Merged
merged 1 commit into from Nov 25, 2021
Merged

Interactions: Unlock controls when play function is finished #16784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/instrumenter/src/instrumenter.ts
View file
Open in desktop
Expand Up @@ -138,6 +138,7 @@ export class Instrumenter {
}
if (newPhase === 'played') {
this.setState(storyId, {
isLocked: false,
isPlaying: false,
isDebugging: false,
forwardedException: undefined,
Expand Down Expand Up @@ -489,7 +490,7 @@ export class Instrumenter {
update(call: Call) {
clearTimeout(this.getState(call.storyId).syncTimeout);
this.channel.emit(EVENTS.CALL, call);
this.setState(call.storyId, ({ calls, isLocked }) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused.

this.setState(call.storyId, ({ calls }) => {
// Omit earlier calls for the same ID, which may have been superceded by a later invocation.
// This typically happens when calls are part of a callback which runs multiple times.
const callsById = calls
Expand Down