Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Rename generated-stories-entry to cjs extension so require works #16727

Merged
merged 9 commits into from Jan 24, 2022
Merged

Core: Rename generated-stories-entry to cjs extension so require works #16727

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e61b63a
Rename to `.cjs` extension so require works.
jpzwarte Nov 19, 2021
b80d1aa
Review fixes.
jpzwarte Nov 22, 2021
dea75df
Merge branch 'next' into pr/16727
shilman Nov 22, 2021
ce26f13
Merge branch 'next' into pr/16727
shilman Dec 2, 2021
85d6f96
Merge branch 'next' into pr/16727
shilman Dec 6, 2021
aa23b98
Merge branch 'next' into pr/16727
shilman Dec 23, 2021
9390d00
Revert "Review fixes."
tmeasday Jan 24, 2022
c14edc6
Add comments explaining discrepencies
tmeasday Jan 24, 2022
07ca419
Merge remote-tracking branch 'origin/next' into jpzwarte-fix-require-…
tmeasday Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/builder-webpack5/src/preview/iframe-webpack.config.ts
View file
Open in desktop
Expand Up @@ -139,7 +139,7 @@ export default async (options: Options & Record<string, any>): Promise<Configura
const storyTemplate = await readTemplate(
path.join(__dirname, 'virtualModuleStory.template.js')
);
const storiesFilename = path.resolve(path.join(workingDir, `generated-stories-entry.js`));
const storiesFilename = path.resolve(path.join(workingDir, `generated-stories-entry.cjs`));
virtualModuleMapping[storiesFilename] = interpolate(storyTemplate, { frameworkImportPath })
// Make sure we also replace quotes for this one
.replace("'{{stories}}'", stories.map(toRequireContextString).join(','));
Expand Down