Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix process.env stringification #16725

Merged
merged 2 commits into from Nov 19, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 19, 2021

Issue: #16381 #16067

What I did

  • Remove one layer of process.env stringification
  • Make process available for NextJS compat

self-merging @tmeasday

How to test

Create a .env file or run with STORYBOOK_X environment vars & console.log(process.env) & console.log(process) in a story

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2021

Nx Cloud Report

CI ran the following commands for commit 876e1c6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 590a5d1.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@shilman shilman added this to the 6.4 PRs milestone Nov 19, 2021
@shilman shilman changed the title Core: Fix double stringification of process.env Core: Fix process.env stringification Nov 19, 2021
@shilman shilman merged commit 9cfc047 into next Nov 19, 2021
@shilman shilman deleted the 16381-fix-process-env-stringification branch November 19, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant