New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactions: Fix various inconsistencies #16465
Conversation
Nx Cloud ReportCI ran the following commands for commit 161598a. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit f9f09ef. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
I tested this out and I have two videos explaining some issues I found when interacting: First, stepping through works great 👍 however clicking directly to the last step fails, as well as when refreshing the browser: observations-1.mov |
Another observation which is a bit more concerning. When the clicking directly to the last step (fails) and rerunning the interaction + clicking again to the last step, every other story gets affected, even the ones that don't have interactions: observations-2.mov |
What happens is the action does get invoked when clicking the last row, but the assertion happens too soon and it's not retried because |
I wonder if retrying when there is an error is common enough to justify a retry action/link/button in the error message itself. |
…kjs/storybook into 16426-callback-call-ids
Issue: #16426
What I did
Fixed how
parentId
is propagated to nested calls.Deduped and sorted the call log so it neatly maps on top of the shadow log (used while debugging), fixing weird behavior with
waitFor
(and potentially other callbacks).How to test
If your answer is yes to any of these, please make sure to include it in your PR.