Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Fix various inconsistencies #16465

Merged
merged 28 commits into from Nov 24, 2021
Merged

Conversation

ghengeveld
Copy link
Member

Issue: #16426

What I did

Fixed how parentId is propagated to nested calls.
Deduped and sorted the call log so it neatly maps on top of the shadow log (used while debugging), fixing weird behavior with waitFor (and potentially other callbacks).

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2021

Nx Cloud Report

CI ran the following commands for commit 161598a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit f9f09ef.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@ghengeveld ghengeveld changed the title 16426 callback call ids Interactions: Fix waitFor behavior while debugging Oct 24, 2021
@yannbf
Copy link
Member

yannbf commented Oct 25, 2021

I tested this out and I have two videos explaining some issues I found when interacting:

First, stepping through works great 👍 however clicking directly to the last step fails, as well as when refreshing the browser:

observations-1.mov

@yannbf
Copy link
Member

yannbf commented Oct 25, 2021

Another observation which is a bit more concerning. When the clicking directly to the last step (fails) and rerunning the interaction + clicking again to the last step, every other story gets affected, even the ones that don't have interactions:

observations-2.mov

@ghengeveld
Copy link
Member Author

What happens is the action does get invoked when clicking the last row, but the assertion happens too soon and it's not retried because waitFor is never retried while debugging. What we should do is allow the user to click 'next' to trigger a retry manually.

@MichaelArestad
Copy link
Contributor

What we should do is allow the user to click 'next' to trigger a retry manually.

I wonder if retrying when there is an error is common enough to justify a retry action/link/button in the error message itself.

@shilman shilman modified the milestone: 6.4 PRs Oct 28, 2021
@ghengeveld ghengeveld changed the title Interactions: Fix waitFor behavior while debugging Interactions: Fix duplicate rows in waitFor Nov 16, 2021
@ghengeveld ghengeveld merged commit ca6a34d into next Nov 24, 2021
@ghengeveld ghengeveld deleted the 16426-callback-call-ids branch November 24, 2021 21:57
@ghengeveld ghengeveld changed the title Interactions: Fix duplicate rows in waitFor Interactions: Fix various inconsistencies Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants