Core: Add framework field support to main.js
#16393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit dc7b2bf. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
tmeasday
approved these changes
Oct 19, 2021
5 tasks
tmeasday
reviewed
Oct 19, 2021
| projectAnnotations.renderToDOM = undefined; | ||
|
|
||
| document.location.search = '?id=component-one--a'; | ||
| const preview = await createAndRenderPreview(); |
There was a problem hiding this comment.
I think just split out createAndRenderPreview in this one case rather than doing the shenanigans with changing projectAnnotations.
Comment on lines
+433
to
+436
| expect(preview.view.showErrorDisplay.mock.calls[0][0]).toMatchInlineSnapshot(` | ||
| [Error: Expected 'framework' in your main.js to export 'renderToDOM', but none found. | ||
|
|
||
| More info: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#mainjs-framework-field ] |
There was a problem hiding this comment.
I think just doing a match on a portion of the message is better than a snapshot here otherwise we'll be updating it all the time as we tweak the message
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16296
What I did
framework: xto CLI for forward-compatibilityHow to test
react-tsexample