CLI: Fix CRA version detection crash #16308
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16306
What I did
When the user specifies
--type react_scripts
or runssb init
in a monorepo where we cannot find thereact-scripts
package version,sb init
crashes.This workaround assumes that we are on CRA4 for now, since that is the latest stable version. It will need to be updated at some point after CRA5 is released.
In addition to this change, I have taken the further action of updating the dist tags for
@storybook/preset-create-react-app
:latest
=3.2.0
next
=4.0.0
This will also need to be updated as soon as CRA5 is released. @tmeasday should I just go ahead and point the CLI to
next
if the app is CRA5?How to test