Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add playback icons #15909

Merged
merged 1 commit into from Aug 25, 2021
Merged

UI: Add playback icons #15909

merged 1 commit into from Aug 25, 2021

Conversation

darleendenno
Copy link
Contributor

What I did

Added a few icons for interaction testing work 馃憖 馃憖 馃憖 (also featured in @storybookjs/design-system)

Screenshots

Screen Shot 2021-08-24 at 16 56 24

Screen Shot 2021-08-24 at 16 56 29

How to test

  • Open Storybook published with PR, and checkout the playback, playnext, and stopalt icons
  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented Aug 24, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 145d5c2. Click to see the status, the terminal output, and the build insights.

馃搨 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 馃拰 from NxCloud.

@darleendenno darleendenno changed the title feat: add playback icons UI: add playback icons Aug 24, 2021
@darleendenno darleendenno added the maintenance User-facing maintenance tasks label Aug 24, 2021
@ghengeveld ghengeveld self-requested a review August 25, 2021 14:27
ghengeveld
ghengeveld approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title UI: add playback icons UI: Add playback icons Aug 25, 2021
@shilman shilman merged commit 77d65ab into next Aug 25, 2021
@shilman shilman deleted the styles/add-playback-icons branch August 25, 2021 14:47
@shilman shilman added this to the 6.4 PRs milestone Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

@shilman shilman Awaiting requested review from shilman

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darleendenno @ghengeveld @shilman