Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI/Storyshots: Specify custom sb extract Chromium exe #15878

Merged
merged 2 commits into from Aug 23, 2021

Conversation

brianblakely
Copy link
Contributor

@brianblakely brianblakely commented Aug 19, 2021

Issue: #13724

What I did

Added environment variable SB_CHROMIUM_PATH, which enables a way to customize the Chromium executable used by sb extract and StoryShots, without an automatic download. StoryShots' existing config-based way of doing this will still work and will take precedence when both are used.

How to test

  1. Download Chromium (you can use Puppeteer's copy in node_modules).
  2. Set the var. It can be an absolute or relative path to the executable.
  3. Run sb extract / a StoryShots + Puppeteer test.
  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Aug 19, 2021

Nx Cloud Report

CI ran the following commands for commit e2ecd86. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title Specify custom sb extract Chromium exe. Fixes #13724. CLI/Storyshots: Specify custom sb extract Chromium exe Aug 23, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @brianblakely -- nice fix 👏 👏 👏

@shilman shilman added this to the 6.4 PRs milestone Aug 23, 2021
@shilman shilman merged commit c24c4cf into storybookjs:next Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants