CLI/Storyshots: Specify custom sb extract Chromium exe #15878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13724
What I did
Added environment variable
SB_CHROMIUM_PATH
, which enables a way to customize the Chromium executable used bysb extract
and StoryShots, without an automatic download. StoryShots' existing config-based way of doing this will still work and will take precedence when both are used.How to test
node_modules
).sb extract
/ a StoryShots + Puppeteer test.If your answer is yes to any of these, please make sure to include it in your PR.