Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Generate and push repros to a GitHub repo every night #15877

Merged
merged 1 commit into from Aug 24, 2021

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Aug 18, 2021

What I did

Added a script to generate and push repros every night. It is using

  • sb repro from the Storybook CLI
  • zx, I discovered it a few weeks (months?) ago and had the opportunity to use it for non-trivial script and I find it really pleasant to use, it simplifies a lot the syntax when writing JS scripts. It could be a great lib to replace all the cross-spawn, spawn etc usages and our custom exec functions we have in the CLI and in the tooling scripts. To discuss with other maintainers 馃槃

TODO

  • Update the READMEs
  • Update the GH user used in the GH Action + generate a PAT for Storybook Bot and update the PAT_STORYBOOK_BOT secret of this repository
  • Make the repo public
  • Add links in the doc? website?

How to test

@nx-cloud
Copy link

nx-cloud bot commented Aug 18, 2021

Nx Cloud Report

CI ran the following commands for commit 582e70a. Click to see the status, the terminal output, and the build insights.

馃搨 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 馃拰 from NxCloud.

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks and removed in progress labels Aug 22, 2021
@gaetanmaisse gaetanmaisse force-pushed the generate-repros branch 2 times, most recently from e8ed31c to b538081 Compare August 22, 2021 12:25
@gaetanmaisse gaetanmaisse marked this pull request as ready for review August 22, 2021 13:25
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great stuff as usual @gaetanmaisse 馃殌

@shilman shilman merged commit a632010 into next Aug 24, 2021
@shilman shilman deleted the generate-repros branch August 24, 2021 18:32
@shilman shilman added this to the 6.4 PRs milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants