CLI: Add --no-open flag #15739
Merged
CLI: Add --no-open flag #15739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Flag to enable not opening the browser (different than --ci)
Nx Cloud ReportCI ran the following commands for commit c66573a. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
approved these changes
Aug 3, 2021
shilman
requested changes
Aug 3, 2021
| @@ -29,6 +29,7 @@ export async function getDevCli(packageJson: { | |||
| .option('--ssl-key <key>', 'Provide an SSL key. (Required with --https)') | |||
| .option('--smoke-test', 'Exit after successful start') | |||
| .option('--ci', "CI mode (skip interactive prompts, don't open browser)") | |||
| .option('--no-open', 'Do not open Storybook automatically in the browser') | |||
There was a problem hiding this comment.
According to commander's docs that's how you set a flag that is true by default and will be set to false when used. With this option set, --open will not be recognized, only --no-open. However, when would anyone ever use the flag --open if that is true by default? 🤔
shilman
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6201
What I did
This PR adds a flag to enable not opening the browser.
How to test
git fetch && git checkout feature/cli-no-open-flagyarn build core-serverFrom there, try it out
Should open Storybook on the browser:
Should not open Storybook on the browser: