Controls: Add id to setter button for undefined values

[revik]

Issue: #15690

What I did

added getControlSetterButtonId function to calculate id of setter button for undefined control values

How to test

added a test for the getControlSetterButtonId function

• Is this testable with Jest or Chromatic screenshots? yes
• Does this need a new example in the kitchen sink apps? no
• Does this need an update to the documentation? no

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 11e3cab. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx run-many --target=prepare --all --parallel --max-parallel=15

---

Sent with 💌 from NxCloud.

[shilman]

Thanks @revik! This is looking pretty good. However, I noticed the following controls are missing: Color, Date, Files, Options, Range, Checkbox, Radio, Select. If we're adding test IDs to some of the controls we should add to all. WDYT?

[revik]

Thanks @revik! This is looking pretty good. However, I noticed the following controls are missing: Color, Date, Files, Options, Range, Checkbox, Radio, Select. If we're adding test IDs to some of the controls we should add to all. WDYT?

@shilman those controls do not display the 'Set' button when no value is sent to them. They all display the control without a specific set value. IMHO - aligning all controls to have the 'Set' button when there is not value set IS the best choice..
Do you want me to try and add it to all of the above controls?

Should this added change be in this PR or in a different one?

[shilman]

Aha, my bad @revik -- I totally missed that. I agree that we should have a unified UI for unset values. I know @tmeasday and @domyen didn't agree before, but I think everybody agrees now. It would be great if you could also fix that in this PR! 🙏

[shilman]

Hi @revik I'm going to merge this in the interest of moving things forward. If you still have any interest, could you please pick up the other changes in a new PR?

[shilman]

Merging despite failing tests. Those tests are already failing on next