fix: react build-storybook hang process #15709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit a08aaee. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
reviewed
Aug 2, 2021
There was a problem hiding this comment.
Thanks for the PR @JayBee007! However, I think this change is redundant with the code that you're wrapping:
https://github.com/storybookjs/storybook/blob/next/lib/core-server/src/build-static.ts#L147-L149
Closing this for now. Please let me know if I'm missing something! 🙏
|
Got it! Thanks for the correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: build-storybook output static files but the process never finishes
What I did
Copied the fix for angular's unfinished build-storybook process from the PR: #15483
How to test
Try to build storybook with a fully controlled custom webpack config on CI/CI