Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(documentation) add typescript.md for main.ts #15629

Closed
wants to merge 1 commit into from

Conversation

mrskiro
Copy link
Contributor

@mrskiro mrskiro commented Jul 19, 2021

What I did

I need ts-node to make the configuration file .ts. I have spent a lot of time trying to figure this out. Therefore, I would like to add this change to the documentation.

You need ts-node to make the configuration file .ts. I have spent a lot of time trying to figure this out. Therefore, I would like to add this change to the documentation.
@nx-cloud
Copy link

nx-cloud bot commented Jul 19, 2021

Nx Cloud Report

CI ran the following commands for commit b136ab8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@mrskiro mrskiro changed the title Update typescript.md for main.ts (documentation) add typescript.md for main.ts Jul 19, 2021
@tyankatsu0105
Copy link
Contributor

And also, main.ts must be CommonJS export syntax like module.exports = {...}.
However, I didn't get some information about the Storybook config with TS.
@purp1eeeee
How do you think about adding section config/TypeScript https://storybook.js.org/docs/xxx/configure/typescript?

@jonniebigodes
Copy link
Contributor

@tyankatsu0105 thanks for the context on this and help with it. I'm good with the suggestion if @purp1eeeee is willing to make it.

Let me know once it's up and we'll go from there.

Stay safe both of you.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 19, 2021
@graup
Copy link
Contributor

graup commented Jul 19, 2021

I'm not sure this is right. I just updated the react-ts example in the repo (#15621) and it works fine without ts-node, you just need to add a babelrc with typescript preset. I guess both are viable solutions.

@shilman
Copy link
Member

shilman commented Jul 21, 2021

Yes @graup that sounds like a better solution to me 💯

@jonniebigodes
Copy link
Contributor

@graup didn't know that it was already addressed by your pull request. @purp1eeeee if you could adjust accordingly we'd appreciate it. Let me know and we'll go from there.

@jonniebigodes
Copy link
Contributor

@purp1eeeee are you ok with adjusting this pull request based on the feedback?

Let me know and we'll go from there. Sounds good?

Stay safe

@jonniebigodes
Copy link
Contributor

@purp1eeeee just a friendly reminder if you're still able to follow up on the feedback and adjust your pull request so that we can look at it and hopefully merge it soon. Let me know and we'll go from there. Looking forward to the updates.

Stay safe

@mrskiro
Copy link
Contributor Author

mrskiro commented Sep 9, 2021

@jonniebigodes
ok. thunks!

@stale
Copy link

stale bot commented Jan 9, 2022

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@jonniebigodes
Copy link
Contributor

@purp1eeeee appreciate the time and effort you've put into this pull request and help us improve our documentation. We've just merged #17358 improving the documentation in this regard. With that, I hope you don't mind, but I'm going to close this pr now as it's now a bit outdated.

Also, @graup appreciate the input and help in this one 🙏 !

Hope both of you have a fantastic weekend!

Stay safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation inactive patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants