Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack5: Quit process after finishing a static build #15483

Merged
merged 2 commits into from Jul 7, 2021
Merged

Webpack5: Quit process after finishing a static build #15483

merged 2 commits into from Jul 7, 2021

Commits on Jul 5, 2021

  1. fix(angular): Quit process after finishing a static build 

    I don't understand why `process.exit` is needed for this particular case
but it seems to fix the issue.

In order to be more safe, I also added a `try`/`catch` and in my own
testing that caught a ngcc locking issue I would have missed otherwise.

Closes #15227.
    @bebraw
    bebraw committed Jul 5, 2021
    Copy the full SHA
    4e1bd0d View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2021

  1. fix: Remember to close webpack compiler 

    It looks like this is the right way to go instead of `process.exit`.
    @bebraw
    bebraw committed Jul 7, 2021
    Copy the full SHA
    9389325 View commit details
    Browse the repository at this point in the history