Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Update Yarn cache setup in GitHub Actions workflow #15480

Merged
merged 3 commits into from Jul 5, 2021
Merged

Build: Update Yarn cache setup in GitHub Actions workflow #15480

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b3ddb6
ci(workflow): add 'npm' cache for actions/setup-node in .github/workf…
oscard0m Jul 4, 2021
4fc9204
fix(workflow): this workflow uses yarn cache
oscard0m Jul 5, 2021
40c5f66
ci(workflow): remove previous cache step
oscard0m Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 12 additions & 16 deletions .github/workflows/tests-unit.yml
View file
Open in desktop
Expand Up @@ -7,19 +7,15 @@ jobs:
name: Core Unit Tests
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v1
with:
node-version: '12.x'
- uses: actions/checkout@v2
- name: Cache node modules
uses: actions/cache@v2
with:
path: node_modules
key: yarn-2-cache-v1-${{ hashFiles('**/yarn.lock') }}
- name: install, bootstrap
run: |
yarn install --immutable
yarn bootstrap --core
- name: test
run: |
yarn test --runInBand --ci
- uses: actions/setup-node@v1
Copy link
Contributor

@merceyz merceyz Jul 7, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering it was added in 2.2.0 you would need to update this to v2, you also need to checkout the code before setting up node so it can actually get the cache folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo are totally right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#15523

with:
node-version: "12.x"
cache: yarn
- uses: actions/checkout@v2
- name: install, bootstrap
run: |
yarn install --immutable
yarn bootstrap --core
- name: test
run: |
yarn test --runInBand --ci