Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add individual story description, see #8527 #10823 #15417

Merged
merged 5 commits into from Jun 30, 2021

Conversation

vidhill
Copy link

@vidhill vidhill commented Jun 29, 2021

Issue:

What I did

Update docs to show how to add individual story description in CSF see #8527 #10823

- I spent a silly amount of time trying to find this piece of info, I want to save the next person the trouble

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need an update to the documentation? n/a

@nx-cloud
Copy link

nx-cloud bot commented Jun 29, 2021

Nx Cloud Report

CI ran the following commands for commit e1a4b2c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the deprecated way of doing it. The recommended way is here:

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#docs-description-parameter

@vidhill
Copy link
Author

vidhill commented Jun 29, 2021

Oh, I did not find that method either, I just updated my example, or is it documented elsewhere?

@shilman
Copy link
Member

shilman commented Jun 29, 2021

@vidhill
Copy link
Author

vidhill commented Jun 29, 2021

Shall I close/cancel this PR so?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging this altho it overlaps with the official docs

@shilman shilman merged commit 221b467 into storybookjs:next Jun 30, 2021
@vidhill vidhill deleted the feature/document-story-description branch July 2, 2021 08:44
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants