Core: Only use dotenv-webpack when a user has a dotenv file #15365
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 1aca2f1. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit 2d4f2f5. Check the Getting started section to configure the app. Sent with 💌 from NxCloud. |
ndelangen
reviewed
Jun 25, 2021
| import path from 'path'; | ||
|
|
||
| // https://github.com/mrsteele/dotenv-webpack/blob/master/src/index.js#L34 | ||
| const DOTENV_FILE = path.join('.', '.env'); |
There was a problem hiding this comment.
Aren't some people defining special environment specific .env files which get auto-loaded?
.prod.env etc?
There was a problem hiding this comment.
Not in our current setup. dotenv-webpack has options to support that, but we don't pass those options in.
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Jun 28, 2021
Core: Only use dotenv-webpack when a user has a dotenv file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14257
What I did
Get rid of webpack5 warning when
dotenv-webpack'sprocess.envdefinition conflicts with our ownDefinePluginusage by simply not using the plugin unless the user has a.envfile in the current directory.This was not a problem in Webpack4, but has gotten more strict in Webpack5.
This PR does not solve the problem where users DO have a
.envfile, but it should remove spurious warnings for users that DON'T.How to test
Not easy to test in the current monorepo setup because we cannot run webpack5