Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Support argType.type.summary when mapping url args #15331

Closed
wants to merge 1 commit into from

Conversation

ghengeveld
Copy link
Member

Issue: #15278

What I did

Sometimes we get a type.summary rather than a type.name, which causes the url args mapping to fail. This fixes that.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2021

Nx Cloud Report

CI ran the following commands for commit 1e7d48d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@ghengeveld
Copy link
Member Author

Closing in favor of #15332

We should just make sure we always have a type.name.

@ghengeveld ghengeveld closed this Jun 23, 2021
@stof stof deleted the argTypes-map-summary branch May 25, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant