Core: Fix storySort order
with whitespace in story paths
#15038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13311
What I did
This consistently splits
kind
in a way that allows whitespace around the path separator. This was already implemented in the stories API usingtrim()
on each part, but a regex separator is more efficient and less fragile. ThestorySort
function didn't do this yet, which is why manually specifying anorder
only worked when including the whitespace in each value (see #13311).Technically this is a breaking change, because it'll break ordering for people who've specified
order
including whitespace. We could circumvent that by trimming values oforder
. WDYT @shilman ?How to test
If your answer is yes to any of these, please make sure to include it in your PR.