Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #14461 #14984

Closed
wants to merge 1 commit into from
Closed

Backport #14461 #14984

wants to merge 1 commit into from

Conversation

penx
Copy link
Contributor

@penx penx commented May 18, 2021

Pass watchOptions from webpack config to webpackDevMiddleware (v3 only)

Backport #14461

Fixes #14342

Pass watchOptions from webpack config to webpackDevMiddleware (v3 only)
@penx penx changed the title Merge pull request #14461 from kaelig/honor-watchoptions Backport #14461 May 18, 2021
@shilman
Copy link
Member

shilman commented May 28, 2021

Given that 6.3 will be released in a few weeks and solves so many other problems, I'd rather users just upgraded. WDYT? #14397

@penx
Copy link
Contributor Author

penx commented May 28, 2021

Hi @shilman, personally I've found another work around with a bit of trial and error on the globs that I was using.

I'd still be concerned about people trying to upgrade to 6.2 in the meantime, encountering this error and trying to debug it - especially as it happens only at runtime so CI checks would likely not block an automated dependency upgrade (though as this issue has been around for a couple of months perhaps no longer a concern).

It depends if you're already planning a 6.2.10 (in which case I think this should be included) - but, if not, perhaps check on #14342 to see if anyone is keen for a fix ASAP or can wait a few weeks.

@shilman
Copy link
Member

shilman commented Jul 12, 2021

closing this as 6.3 has been released

@shilman shilman closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants