Core: Fix features, core, logLevel in main.js config types
#14745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 6b8c8b5. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
changed the title
features to the StorybookConfig typefeatures to the StorybookConfig type
shilman
reviewed
Apr 28, 2021
There was a problem hiding this comment.
@valerybugakov great addition! however I only see features added. Did you forget to check something in?
|
@shilman, right, I've pushed the last commit 👍 |
shilman
changed the title
features to the StorybookConfig typefeatures, core, logLevel in main.js config types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
featuressetting was added recently to themain.jsconfig. It's not reflected in theStorybookConfigtype.What I did
Added
features,coreandloglevelto theStorybookConfigtype.How to test
Updated usage of
StorybookConfigin examples should throw an error if the config type doesn't have some field.